Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates #1944

Merged
merged 18 commits into from
Jul 25, 2023
Merged

Dependency updates #1944

merged 18 commits into from
Jul 25, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Jul 24, 2023 •
edited
Loading

A hell lot of breaking things...

  • Mostly the storybook update to version 7 required a lot of adjustments how stories are written as well as how dependencies are provided. It seems like the support for standalone components is now even better (requires less boilerplate) but the existing approach did not work anymore. While adjusting these I also fixed a few stories so there will be some conflicts on percy once we get some new quota.
  • I cleaned up the tsconfig files to fix the wrong types we sometimes had in the test files (it used Chai/Mocha instead of Jasmine types).
  • Faker had a major update with a lot of deprecated/changed a few APIs
  • ESlint had an update which required lint changes and also included special rules for stories

@github-actions
Copy link

Deployed to https://pr-1944.aam-digital.net/

TheSlimvReal
TheSlimvReal commented Jul 24, 2023
View reviewed changes
src/polyfills.ts
* BROWSER POLYFILLS
*/
/** Evergreen browsers require these. **/
import "core-js/es/reflect";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find anything that indicates that this is actually still needed. New angular projects don't come with it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sleidig
sleidig approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! ❤️

@TheSlimvReal TheSlimvReal merged commit 484ee47 into master Jul 25, 2023
@TheSlimvReal TheSlimvReal deleted the dependency_updates branch July 25, 2023 11:11
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.22.0-master.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSlimvReal @aam-digital-ci @sleidig